Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update type annotations, minor refactors, better error messages #844

Merged
merged 2 commits into from
Feb 4, 2025

Conversation

TheLeoP
Copy link
Contributor

@TheLeoP TheLeoP commented Feb 3, 2025

Describe what this PR does / why we need it

  • Updates type annotations to make it easier to work with the codebase
  • Simplifies the logic of some small functions
  • uses vim.json.encode/decode instead of vim.fn.json_encode/decode
  • Adds better error messages to repo/number parsing to make it easier to catch regressions like Error with Oct Autocommands #841

Does this pull request fix one issue?

NONE

Describe how you did it

  • I checked the code to manually infer better type annotations for functions signatures.

Describe how to verify it

The tests should still pass after the small refactors

Special notes for reviews

Checklist

  • Passing tests and linting standards
  • Documentation updates in README.md and doc/octo.txt

Copy link
Collaborator

@wd60622 wd60622 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. Thanks!

@wd60622 wd60622 merged commit 08359aa into pwntester:master Feb 4, 2025
3 checks passed
@TheLeoP TheLeoP deleted the update_fzf_lua branch February 4, 2025 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants